scx_layered: handle nr_to_free calculation #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htejun
reviewed
Dec 8, 2024
scheds/rust/scx_layered/src/main.rs
Outdated
| nr_to_free = 0 | ||
| } else { | ||
| nr_to_free -= nr_freed; | ||
| } |
There was a problem hiding this comment.
Can we do nr_to_free.saturating_sub(nr_freed)?
luigidematteis
force-pushed
the
fix-cpus-freed-subtraction-overflow
branch
from
d1a9ed3 to
19e57e3
Compare
Ensure nr_to_free is correctly handled to prevent subtraction overflow. Added a check to set nr_to_free to 0 if nr_freed > nr_to_free. Resolves sched-ext#1072 Signed-off-by: Luigi De Matteis <ldematteis123@gmail.com>
luigidematteis
force-pushed
the
fix-cpus-freed-subtraction-overflow
branch
from
19e57e3 to
b73e505
Compare
htejun
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
nr_to_freeinscx_layered/src/main.rsis assigned an incorrect value due to a subtraction overflow, as reported in this issue #1072.Ensure
nr_to_freeis correctly handled to prevent subtraction overflow, adding a check to setnr_to_freeto 0 ifnr_freed>nr_to_free.