Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for dsq_lat.bt #1077

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Fixes for dsq_lat.bt #1077

merged 1 commit into from
Dec 8, 2024

Conversation

samuelnair
Copy link

  • Fix to ensure that we can track dsq id 0
  • Cleans up some warnings
  • Clean up some maps to avoid them printing out a bunch of output that was not really helpful

@samuelnair samuelnair requested a review from hodgesds December 8, 2024 17:37
Copy link
Contributor

@hodgesds hodgesds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have another bpftrace script that I'm working on where I just add 1 to the DSQ id to get around handling dsq 0 for zero value map entries. It's kind of annoying but you end up just subtracting 1 when printing and it sort of works.

@htejun
Copy link
Contributor

htejun commented Dec 8, 2024

Longer term, it'd probably make sense to invest a bit more effort into making these scripts more customized to our purposes using e.g. bcc. The default histogram implementation is really not great, DSQ IDs are a lot better printed in hex and so on.

@likewhatevs
Copy link
Contributor

Longer term, it'd probably make sense to invest a bit more effort into making these scripts more customized to our purposes using e.g. bcc. The default histogram implementation is really not great, DSQ IDs are a lot better printed in hex and so on.

I have no idea how practical this is, but I'm gonna take a swing at writing a rust cli that uses small bpf functions to show info these scripts retrieve in a easier to read manner.

@hodgesds hodgesds added this pull request to the merge queue Dec 8, 2024
Merged via the queue into sched-ext:main with commit 8ecbea6 Dec 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants