only compile library when using recent bpftool versions #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etsal
force-pushed
the
etsal/no-library-old-bpftool
branch
from
b5f2b93 to
a6ea2b4
Compare
etsal
force-pushed
the
etsal/no-library-old-bpftool
branch
from
a6ea2b4 to
c5c4cae
Compare
hodgesds
reviewed
Dec 9, 2024
| output: scx_lib_name + '.bpf.o', | ||
| command: [compile_scx_lib, bpftool_exe_path, '@OUTPUT@', scx_lib_name, objs], | ||
| depends: objs, | ||
| if bpftool_maj < 7 or (bpftool_maj == 7 and bpftool_min >= 5) |
There was a problem hiding this comment.
Probably worth adding a comment on why this is needed.
etsal
added a commit
to etsal/scx
that referenced
this pull request
Dec 10, 2024
…tool only compile library when using recent bpftool versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scx users have bpftool versions < 7.5.0, causing Meson system to throw errors when linking in the BPF library to schedulers. Add a workaround by only compiling the library when the bpftool is new enough.