scx_layered, cpumask, topology: Cleanups #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- layered now wraps topology in Arc and stores it in CpuPool::topo. - CpuPool::nr_cores -> topo.all_cores.len(). - CpuPool::nr_cpus -> NR_CPU_IDS, NR_CPUS_POSSIBLE or topo.all_cpus.len() depending on the context. layered is still pretty broken in that it's assuming all three values to be equal. - CpuPool::all_cpus -> topo.all_cpus(). - CpuPool::cpu_core -> topo.all_cpus[].core_id. - CpuPool::core_cpus usage converted to use topo.all_cores. - Drop Topology::nr_cpus_online as .all_cpus.len()) providse the same info. - Drop Toplogy::cpus_bitvec(). No user left.
- Use Cpumask instead BitVec at least in interfaces. - When BitVec is used use <u64, Lsb0> variant to be compatible with Cpumask.
- Drop Result<> from new(). - Rename interface functions for consistency.
…e &Rhs Down the line, we should ditch BitVec and convert it into an inline implementation which is Copy.
- Use information in CpuPool::topo instead. - Use Cpumasks instead of BitVecs in CpuPool body. CpuPool::cpus_to_cores() was incorrectly updated to return Cpumask when it's returning a bitmap of cores. Fix it. - This leaves TopologyMap without any users. Drop it.
Use topo.sibling_cpus() directly instead.
likewhatevs
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things got a bit messy over time e.g. with
TopologyMapduplicating parts ofTopologyandCpuPoolhaving a lot ofTopologyfeatures. Let's clean them up. This shouldn't cause any behavior changes.