Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump libbpf-rs version to 0.24.8, specify libbpf-sys version 1.4.6+1.4.7 #1089

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

etsal
Copy link
Contributor

@etsal etsal commented Dec 10, 2024

This is a redo of #1087 which was accidentally closed.

@etsal etsal requested a review from likewhatevs December 10, 2024 15:44
@etsal etsal force-pushed the etsal/bump-libbpf-rs branch from 9bc077c to a55e3f1 Compare December 10, 2024 18:04
@likewhatevs
Copy link
Contributor

I think you need to remove the revert commit to make this do what is intended (no changes atm).

Copy link
Contributor

@likewhatevs likewhatevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signals are solid wrt/ what this touches, once green lets do it.

@etsal
Copy link
Contributor Author

etsal commented Dec 11, 2024

I think you need to remove the revert commit to make this do what is intended (no changes atm).

Oh yeah, I added a revert commit to try to see whether the CI breakage we were seeing was caused by the commit or if it was an issue with the ppas.

@etsal etsal force-pushed the etsal/bump-libbpf-rs branch from a55e3f1 to 0fb3f25 Compare December 11, 2024 02:19
@likewhatevs
Copy link
Contributor

Ahh btw, because we're using head of the sched_ext repo on kernel.org, main is built hourly to help us see issues like this one (i.e. if you ever suspect that, just check CI status on main, it'll be red if that's the case).

@etsal etsal force-pushed the etsal/bump-libbpf-rs branch from 0fb3f25 to 684b64e Compare December 11, 2024 15:20
@etsal etsal enabled auto-merge December 11, 2024 16:25
@etsal etsal added this pull request to the merge queue Dec 11, 2024
Merged via the queue into sched-ext:main with commit 5960298 Dec 11, 2024
23 checks passed
@etsal etsal deleted the etsal/bump-libbpf-rs branch December 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants