Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_layered: queued_runtime tracking bug fix and disable xllc_mig_min_us by default #1093

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

htejun
Copy link
Contributor

@htejun htejun commented Dec 11, 2024

No description provided.

When a task gets dequeued and its property is changed so that it belongs to
a different layer and then requeued, the current qrt tracking code deducts
its runtime_avg from the wrong layer which leads to e.g. qrt underflows.
Remember the layer the runtime is charged to and deduct it from there.
100us doesn't necessarily seem to behave better. Turn it off by default.
Copy link
Contributor

@likewhatevs likewhatevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Copy link
Contributor

@hodgesds hodgesds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htejun htejun added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 1ce3cfb Dec 11, 2024
46 checks passed
@htejun htejun deleted the htejun/layered-updates branch December 11, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants