scx_loader: Avoid race condition with start_scheduler #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RunnerMessage::Switch is called frequently, start_scheduler could encounter a race condition issue, where more than one tokio async task would start the same time, messing with the child_id state. To resolve this issue, the JoinHandle got in start_scheduler is recorded, and instead of using child_id to send SIGINT, a cancellation token from tokio-util is used, and stop_scheduler uses it to inform the async task to kill its child. And we could ensure that only one task is managing spawned scheduler process.
taoky
added a commit
to taoky/scripts
that referenced
this pull request
Jan 20, 2025
vnepogodin
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RunnerMessage::Switch is called frequently, start_scheduler could encounter a race condition issue, where more than one tokio async task would start the same time, messing with the child_id state.
To resolve this issue, the JoinHandle got in start_scheduler is recorded, and instead of using child_id to send SIGINT, a cancellation token from tokio-util is used, and stop_scheduler uses it to inform the async task to kill its child. And we could ensure that only one task is managing spawned scheduler process.