ci: switch scheduled jobs to nix built kernel #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, this doesn't work until after switching to the Nix kernels because of the currently different suffixes. Will hold off until that gets switched on. |
JakeHillion
force-pushed
the
reusable-cache-kernel
branch
2 times, most recently
from
caa1889 to
cbac042
Compare
JakeHillion
changed the title
Create a reusable GitHub action to restore the kernel cache. This takes an argument for `git-repo` and `branch`, like the equivalent reusable workflow for building a Nix kernel. Enable this action for the Nix built kernels in the scheduled runs. This reduces the possibility for a mis-copy and significantly simplifies the files compared to duplicating the code. Note that this is deliberately ordered before the `tar` setuid bit in the actions, as the new cache and that change don't interact well. Will drop that setuid step in future changes but leaving it there for now to load the other caches. Drive by: remove lint from the for-next scheduled run. It's already checked on PRs, in the merge queue, and on the scheduled main run. Test plan: - Changed one of the cache loads to the `master` branch to guarantee a miss. Workflow fails as expected. - Tested scheduled workflows by enabling them temporarily on `push`. They pass.
JakeHillion
force-pushed
the
reusable-cache-kernel
branch
from
cbac042 to
b6fe177
Compare
|
Still using the generic action but now applying it to the scheduled runs. They've been successful at building the kernel - I looked at the last 20 or so, and one even built when the GH actions runner failed (a timeout I think). Will switch them over to the new kernel and keep an eye, then follow with the more relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a reusable GitHub action to restore the kernel cache. This takes an
argument for
git-repoandbranch, like the equivalent reusable workflow forbuilding a Nix kernel. Enable this action for the Nix built kernels in the
scheduled runs.
This reduces the possibility for a mis-copy and significantly simplifies the
files compared to duplicating the code.
Note that this is deliberately ordered before the
tarsetuid bit in theactions, as the new cache and that change don't interact well. Will drop that
setuid step in future changes but leaving it there for now to load the other
caches.
Drive by: remove lint from the for-next scheduled run. It's already checked on
PRs, in the merge queue, and on the scheduled main run.
Test plan:
masterbranch to guarantee a miss.Workflow fails as expected.
push. They pass.