Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_bpfland: convert scheduler crate into lib+bin crate #567

Closed

Conversation

vnepogodin
Copy link
Contributor

@vnepogodin vnepogodin commented Aug 26, 2024

This PR converts scheduler scx_bpfland crate into lib+bin crate, to be able to use(load/unload) scheduler by other crates

convert scheduler crate into lib+bin crate, to be able to
use(load/unload) scheduler by other crates

required for sched-ext#565
@arighi
Copy link
Contributor

arighi commented Aug 26, 2024

I really like the idea of providing the Rust schedulers both as binaries and libraries! This can facilitate the development of tools / managers / meta-schedulers, simply by importing them as "libraries".

I'm not sure if it's better to create separate PRs or make a single PR. Also this may impact the workflow and potentially pending changes that people may have. We should discuss this during office hours to make sure everyone is aware (and agree with this) to better coordinate this change.

@vnepogodin
Copy link
Contributor Author

vnepogodin commented Aug 26, 2024

I'm not sure if it's better to create separate PRs or make a single PR. Also this may impact the workflow and potentially pending changes that people may have. We should discuss this during office hours to make sure everyone is aware (and agree with this) to better coordinate this change.

yeah I agree with that

@arighi
Copy link
Contributor

arighi commented Sep 5, 2024

I'm going to close this one for now. I think the plan is to have scx_loader running the scheduler binaries first, then at some point in the future we may decide to resume thiis lib/bin approach. Feel free to re-open it if needed.

@arighi arighi closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants