Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoodJob isn't working on ruby 3.2 and rails 6.1.7.8 #705

Closed
1 task
ShanaLMoore opened this issue Jul 23, 2024 · 2 comments
Closed
1 task

GoodJob isn't working on ruby 3.2 and rails 6.1.7.8 #705

ShanaLMoore opened this issue Jul 23, 2024 · 2 comments
Assignees
@ShanaLMoore

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jul 23, 2024 •
edited
Loading

Summary

Adventist uses good jobs for their background worker. Since valkyrizing their application, good job produces the following error and refuses to run.

Image

Acceptance Criteria

  • The application successfully uses good jobs as its background worker.

Notes

Hyku uses sidekiq due to trouble getting good jobs to work

related issue reported
related solution

  • why did this change?
    • it was changed in the latest hyku release v6.0 to point to a released rails version

Image
@ShanaLMoore ShanaLMoore changed the title GoodJob isn't working GoodJob isn't working on ruby 3.2 and rails 6.1.7.8 Jul 23, 2024
@ShanaLMoore ShanaLMoore self-assigned this Jul 23, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jul 23, 2024 •
edited
Loading

🎉 https://hyku.test/jobs/jobs =>

Image

@ShanaLMoore
Copy link
Contributor Author

We reverted back to 6-1-stable via the gem override/bundler inject pattern.

Devs either will need to rebuild after pulling in the changes, or manually copy bundler.d/ to /app/.bundler.d/

ShanaLMoore added a commit to samvera/hyku that referenced this issue Aug 7, 2024
@ShanaLMoore
🧹 locks rails to support good jobs
828da44 
This specific commit is needed for good jobs to work.

ref:
- scientist-softserv/adventist_knapsack#705
@ShanaLMoore ShanaLMoore mentioned this issue Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShanaLMoore