🧹 Add FormTermsDecorator #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will make the base primary terms match adventist proper. Issue: - https://github.com/scientist-softserv/adventist-dl/issues/585 Co-Authored-By: Kirk Wang <k3wang@gmail.com>
FormTermsDecorator was not being correctly loaded by the GenericWorkForm and ImageForm because even though FormTerms was being decorated, it did not carry down to these classes which included it.
This commit will fix locales that were being loaded instead of the ones from the Dog Biscuit ymls.
laritakr
approved these changes
Oct 3, 2023
ShanaLMoore
pushed a commit
that referenced
this pull request
Jul 17, 2024
update engine.rb to specify engine root for migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Story
Refs #issuenumber
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes