Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Python 3.9 across all backends #1574

Merged
merged 9 commits into from
Sep 2, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 1, 2021

Description

pyhf is already Python 3.9 compliant, with the exception of TensorFlow. With PR #1000, this will be resolved and all pyhf backends can be tested against Python 3.9.

.github/workflows/release_tests.yml won't get updated yet though as there is no Python 3.9 release out to test against.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add official support for Python 3.9 and add Python 3.9 to CI
   - Required PR #1001 to get Python 3.9 support of TensorFlow and TensorFlow Probability
* Add Python 3.9 support to PyPI metadata
* Update GitHub Actions workflows to use Python 3.9
   - .github/workflows/release_tests.yml will be updated after pyhf v0.6.3 is released
* Update Dockerfile to use python:3.9-slim-bullseye as base image

@matthewfeickert matthewfeickert added feat/enhancement New feature or request CI CI systems, GitHub Actions build Changes that affect the build system or external dependencies Docker Involving Docker images or builds labels Sep 1, 2021
@matthewfeickert matthewfeickert self-assigned this Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1574 (5b013c5) into master (5247c16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1574   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4050     4050           
  Branches      576      576           
=======================================
  Hits         3957     3957           
  Misses         54       54           
  Partials       39       39           
Flag Coverage Δ
contrib 25.43% <ø> (ø)
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5247c16...5b013c5. Read the comment docs.

@matthewfeickert matthewfeickert force-pushed the feat/update-to-python3.9-support branch from 17d98ad to 5b013c5 Compare September 2, 2021 16:32
@matthewfeickert matthewfeickert marked this pull request as ready for review September 2, 2021 16:38
@matthewfeickert
Copy link
Member Author

.github/workflows/release_tests.yml should be updated once v0.6.3 is out and there is a Python 3.9 release to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies CI CI systems, GitHub Actions Docker Involving Docker images or builds feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.9
1 participant