Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set lower bound of scipy v1.1.0 #1661

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 22, 2021

Description

With tensorflow now v2.3+ given PR #1657, the scipy requirement of v1.4.1 has been lifted (c.f. PR #1001) as SciPy was removed as a TensorFlow dependency in tensorflow v2.3.1. This lifts the requirements on SciPy, and the oldest version that still has Python 3.7 wheels is scipy v1.1.0.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Set the lower bound of the supported SciPy versions to scipy v1.1.0
   - scipy v1.1.0 is the oldest SciPy release with Python 3.7 wheels

@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Oct 22, 2021
@matthewfeickert matthewfeickert self-assigned this Oct 22, 2021
@matthewfeickert matthewfeickert added the tests pytest label Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1661 (16867d4) into master (f5dab71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          64       64           
  Lines        4216     4216           
  Branches      585      585           
=======================================
  Hits         4135     4135           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 25.30% <ø> (ø)
doctest 61.05% <ø> (ø)
unittests 96.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dab71...16867d4. Read the comment docs.

@matthewfeickert matthewfeickert force-pushed the tests/bump-min-scipy-lower branch from af56db2 to 1065a29 Compare October 22, 2021 18:17
@matthewfeickert matthewfeickert marked this pull request as ready for review October 22, 2021 18:21
@kratsg kratsg merged commit 6ade6d4 into master Oct 22, 2021
@kratsg kratsg deleted the tests/bump-min-scipy-lower branch October 22, 2021 20:25
@matthewfeickert matthewfeickert added the dependencies Pull requests that update a dependency file label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies dependencies Pull requests that update a dependency file tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants