-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow zero rate Poisson #1657
Conversation
Effectivley reverts most of PR 1001
* Reverts most of PR 280 * Reapplies PR 277 by Ruggero Co-authored-by: Ruggero Turra <giurrero@gmail.com>
cc @wiso, @alexander-held, @andrewfowlie as you've all participated in discussion on Issue #293. |
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 63 63
Lines 4145 4142 -3
Branches 572 572
==========================================
- Hits 4064 4061 -3
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Allow zero rate Poisson under the case that the limit
\lambda -> 0
is well defined asThis PR enforces the default behavior across all backends.
This PR effectively reverts most of PR #1001 and PR #280, and reapplies most of @wiso's PR #277.
To allow for zero rate Poisson across all backends, the mimimum required versions are adjusted:
v0.11.0
, which requirestensorflow>=2.3
(c.f. Motivation for allowing zero rate in Poisson in v0.11.0? tensorflow/probability#1025). As a result, the minimum compatible releases are bumped to TensorFlowv2.3.1
and TensorFlow Probabilityv0.11.0
.v1.10.0
, so the minimum compatible release is set to that.Note, that Issue #293 introduces the idea of a cutoff. That isn't off the table, but should be discussed in a separate Issue.
(Self note: As it will probably come up again at some point, the first citation of this being a thing that I can find is from this Cross Validated post.)
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: