Fix: bug in benchmark tests #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for getting this, @kratsg.
Now that I think about it |
kratsg
changed the base branch from
master
to
feature/use-distributions-in-ML-backends-for-better-poisson
matthewfeickert
force-pushed
the
feature/use-distributions-in-ML-backends-for-better-poisson
branch
from
975805b to
94b6e8e
Compare
2 tasks
This reverts commit cbb899f.
kratsg
force-pushed
the
bug/benchmarkTests
branch
from
0cc08fe to
5f371ea
Compare
|
rebased against #268 to prepare |
matthewfeickert
merged commit fafe676
into
feature/use-distributions-in-ML-backends-for-better-poisson
4 tasks
lukasheinrich
pushed a commit
that referenced
this pull request
Oct 22, 2021
* Effectively reverts most of PR #1001 and PR #280, reapplies most of PR #277 * Use scipy.special.xlogy in Poisson computation for numpy backend and use jax.scipy.special.xlogy for jax backend * Set minimum required PyTorch to v1.10 for API stability - c.f. pytorch/pytorch#61511 in torch v1.10.0 * Set minimum required TensorFlow to v2.3.1 and TensorFlow Probability to v0.11.0 - tfp v0.11.0 supports zero rate Poisson and requires tensorflow>=2.3.0 * Add note to docs that limit Poisson(n = 0 | lambda -> 0) = 1 is being used * Update tests to use limit Poisson(n = 0 | lambda -> 0) = 1 result * Run doctest on only the latest Python release Co-authored-by: Ruggero Turra <giurrero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The benchmark tests were not running because of forgetting to
pip install minuitdependency. This was introduced through #276 which imports the minuit optimizer intests/conftest.pywhich raises the exception.This also reverts the unfortunate regression introduced by #277 as we don't have equivalent methods to return
0for the other backends, and whether thepoissonforlambda=0should return 0 orNaNis probably not well-defined? (correct me if I'm wrong).Checklist Before Requesting Approver