-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: (automatically) set backends through a fixture #276
Merged
+163
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are breaking currently, see scikit-hep/uproot3#130. |
Fixed with scikit-hep/uproot3-methods#1. |
1 similar comment
2 tasks
matthewfeickert
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to make testing a lot easier for us moving forward as we start having complexity problems with testing combinations of backends+optimizers and so on and lots of duplicated code. In particular, the fixture is called
backend
so adding abackend
parameter to any test function you have will automatically wrap that function in setting up the backend correctly, and breaking it down after the test runs. This can be useful with certain backends like tensorflow that need a new session or its internal graph cleared.Additionally, some extra decorations (
pytest.mark
s) are specified to make this even easier to fine-tune which backends run. Right now, we add 5:numpy
,tensorflow
,pytorch
,mxnet
,numpy_minuit
. The last one is numpy with the minuit optimizer.One can specify, for example, to only run
numpy
andnumpy_minuit
or
will be equivalent. The latter will not skip any new backends that get added after this PR, but the former will still only consider those two.
Similarly, if you expect a particular backend to fail for any reason, you can mark that specific backend as failing via
@pytest.mark.fail_tensorflow
for example.
Checklist Before Requesting Approver