Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add filterwarnings ignore for np.bool8 DeprecationWarning #2072

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

matthewfeickert
Copy link
Member

Description

Add a ignore to filterwarnings to avoid a numpy DeprecationWarning

DeprecationWarning: np.bool8 is a deprecated alias for np.bool_. (Deprecated NumPy 1.24)

from TensorFlow's use of numpy. This DeprecationWarning first appeared in numpy v1.24.0rc1, and so this ignore is being added in advance of v1.24.0 as a preventative measure for HEAD of dependencies testing.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add a ignore to filterwarnings to avoid a numpy DeprecationWarning

> DeprecationWarning: `np.bool8` is a deprecated alias for `np.bool_`.  (Deprecated NumPy 1.24)

from TensorFlow's use of numpy. This DeprecationWarning first appeared in
numpy v1.24.0rc1, and so this ignore is being added in advance of
v1.24.0 as a preventative measure for HEAD of dependencies testing.

* Add a ignore to filterwarnings to avoid a numpy DeprecationWarning

> DeprecationWarning: `np.bool8` is a deprecated alias for `np.bool_`.  (Deprecated NumPy 1.24)

from TensorFlow's use of numpy. This DeprecationWarning first appeared in
numpy v1.24.0rc1, and so this ignore is being added in advance of
v1.24.0 as a preventative measure for HEAD of dependencies testing.
@matthewfeickert matthewfeickert added fix A bug fix chore Other changes that don't modify src or test files labels Dec 3, 2022
@matthewfeickert matthewfeickert self-assigned this Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (e511a9c) compared to base (3d68fc7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2072   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4530     4530           
  Branches      645      645           
=======================================
  Hits         4453     4453           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.14% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 9e16408 into main Dec 4, 2022
@matthewfeickert matthewfeickert deleted the chore/filterwarnings-ignore-numpy branch December 4, 2022 00:29
matthewfeickert added a commit that referenced this pull request Mar 31, 2023
* Backport PR #2095 to the release/v0.7.x branch for easier comparisons.
* Also backport components of:
    - PR #2072
    - PR #2099
    - PR #2100
    - PR #2119
    - PR #2125
    - PR #2145
* In filterwarnings ignore all DeprecationWarning on patch release branches
  (e.g. release/v0.7.x).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant