-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Environment :: WebAssembly :: Emscripten PyPI trove classifier #2100
Conversation
@henryiii maybe we should add these to all the Scikit-HEP packages that currently work in |
I opened up pypa/hatch#725 as |
This will also require bumping [build-system]
- requires = ["hatchling>=1.0.0", "hatch-vcs"]
+ requires = ["hatchling>=1.12.3", "hatch-vcs>=0.3.0"] # c.f. PR #2100 assuming this fix would get into |
To be clear, |
pyproject.toml
Outdated
"Environment :: WebAssembly", | ||
"Environment :: WebAssembly :: Emscripten", | ||
"Environment :: WebAssembly :: WASI", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Environment :: WebAssembly", | |
"Environment :: WebAssembly :: Emscripten", | |
"Environment :: WebAssembly :: WASI", | |
"Environment :: WebAssembly :: Emscripten", |
As @brettcannon reminds me, NumPy and SciPy work with Emscripten, but they don't cleanly work with WASI in a way that would merit the WASI
support classifier.
* Add PyPI trove classifiers to the PyPI metadata for Environment :: WebAssembly as pyhf can run on a WASM build of CPython. - c.f. https://discuss.python.org/t/do-we-want-classifiers-for-webassembly-on-pypi/22712
31d969d
to
6a07979
Compare
Codecov ReportBase: 98.30% // Head: 98.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 69 69
Lines 4531 4531
Branches 645 645
=======================================
Hits 4454 4454
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
Description
Add PyPI trove classifiers to the PyPI metadata for
Environment :: WebAssembly :: Emscripten
as pyhf can run on a WASM build of CPython.Thanks to @treyhunner for sharing this on Twitter and to @brettcannon for adding them in pypa/trove-classifiers#129. 👍
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: