fix: Use Path object for jupyterlite-sphinx jupyterlite_dir config #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* To avoid warning ``` WARNING: The config value `jupyterlite_dir' has type `str', defaults to `PosixPath'. ``` use a pathlib.Path for the jupyterlite-sphinx jupyterlite_dir config option.
matthewfeickert
added
docs
|
I'm going to approve and merge this myself in the interest of finishing out Issue #2289. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 69 69
Lines 4536 4536
Branches 802 802
=======================================
Hits 4459 4459
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
41 tasks
4 tasks
matthewfeickert
removed
the
need-to-backport
matthewfeickert
added a commit
that referenced
this pull request
Sep 6, 2023
4 tasks
matthewfeickert
added a commit
that referenced
this pull request
Mar 22, 2024
) * To avoid warning WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`. use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config option. * Update jupyterlite-sphinx lower bound to v0.13.1 in 'docs' extra. * Amends PR #2300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2299
To avoid warning
use a
pathlib.Pathfor thejupyterlite-sphinxv0.9.1jupyterlite_dirconfig option.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: