Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore World Scientific journal URLs during Sphinx linkcheck #2308

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Avoids:

403 Client Error: Forbidden for url: https://www.worldscientific.com/doi/abs/10.1142/S0217732321020016

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ignore URLs for World Scientific journal article
 https://doi.org/10.1142/S0217732321020016 from Sphinx linkcheck tests.

 Avoids:

403 Client Error: Forbidden for url:
https://www.worldscientific.com/doi/abs/10.1142/S0217732321020016

* Ignore URLs for World Scientific journal article
 https://doi.org/10.1142/S0217732321020016 from Sphinx linkcheck tests.

 Avoids:

```
403 Client Error: Forbidden for url:
https://www.worldscientific.com/doi/abs/10.1142/S0217732321020016
```
@matthewfeickert matthewfeickert added docs Documentation related tests pytest need-to-backport tmp label until can be backported to patch release branch labels Aug 30, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4c7248) 98.30% compared to head (033ac26) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4536     4536           
  Branches      802      802           
=======================================
  Hits         4459     4459           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.04% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.34% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit d9b079f into main Aug 30, 2023
@matthewfeickert matthewfeickert deleted the test/ignore-link-for-linkcheck branch August 30, 2023 23:34
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Sep 6, 2023
matthewfeickert added a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant