Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rntuple tests to 6.29 and adding more #111

Merged
merged 1 commit into from
Jan 5, 2023
Merged

update rntuple tests to 6.29 and adding more #111

merged 1 commit into from
Jan 5, 2023

Conversation

Moelf
Copy link
Collaborator

@Moelf Moelf commented Jan 5, 2023 •
edited
Loading

  • add macro for generating the bit (bool) test file
  • add multi-cluster tests
  • cover more stuff in stl container test file (this may make uproot tests fail for now)

@Moelf
Copy link
Collaborator Author

Moelf commented Jan 5, 2023

the new stl looks like this:

@coveralls
Copy link

Coverage Status

Coverage: 62.736%. Remained the same when pulling ae650e3 on Moelf:update_rntuple_tests into 1d55b9f on scikit-hep:main.

jpivarski
jpivarski approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! These are needed for scikit-hep/uproot5#705.

@jpivarski jpivarski merged commit 94f131b into scikit-hep:main Jan 5, 2023
@jpivarski jpivarski mentioned this pull request Jan 6, 2023
Merged
@ioanaif ioanaif mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
new ROOT data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moelf @coveralls @jpivarski @eduardo-rodrigues