Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uproot ntuple 6.29/01 files #131

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Oct 17, 2023

Files used in uproot PR 962 ; taken from UnROOT PR 262

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a378af0) 69.78% compared to head (4321d0c) 69.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   69.78%   69.78%           
=======================================
  Files           3        3           
  Lines         139      139           
=======================================
  Hits           97       97           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf
Copy link
Collaborator

Moelf commented Oct 17, 2023

I think you also want to include the original .C source files maybe?

@ioanaif
Copy link
Collaborator Author

ioanaif commented Oct 17, 2023

I don't believe it's needed for uproot testing; I was thinking if someone needs to check it, they can do so through the UnROOT PR.

@Moelf
Copy link
Collaborator

Moelf commented Oct 17, 2023

@jpivarski
Copy link
Member

Keeping the .C files is better, since it makes it easier to produce new ROOT files when the RNTuple format changes again. So if you have them, please do add them.

@ioanaif
Copy link
Collaborator Author

ioanaif commented Oct 17, 2023

Ah, I didn't know about the /dev/make-root part.

Then, the .C files are already present (previously added and I didn't change anything to the .C files).

However, the .root test files that are already in scikit-hep-testdata, are not the ones used in JuliaHEP/UnROOT.jl#264.

The .root files were added in January #111 and the update was done in June JuliaHEP/UnROOT.jl#264

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, if the .C files weren't changed and there's now a reference here connecting the ROOT file with them, then that's all that's needed for posterity. I'll merge this and make a new release.

@jpivarski jpivarski merged commit a3d7245 into main Oct 17, 2023
@jpivarski jpivarski deleted the ioanaif/add-uproot-new-rntuple-test-files branch October 17, 2023 18:59
@Moelf
Copy link
Collaborator

Moelf commented Oct 17, 2023

what I intended to do (and what I do for UnROOT.jl) is that I will refresh/replace the .root file when there's a new ROOT breaking change release, until they hit stable release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants