-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add uproot ntuple 6.29/01 files #131
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 69.78% 69.78%
=======================================
Files 3 3
Lines 139 139
=======================================
Hits 97 97
Misses 42 42 ☔ View full report in Codecov by Sentry. |
I think you also want to include the original |
I don't believe it's needed for |
I try to keep them anyway xD |
Keeping the .C files is better, since it makes it easier to produce new ROOT files when the RNTuple format changes again. So if you have them, please do add them. |
Ah, I didn't know about the /dev/make-root part. Then, the .C files are already present (previously added and I didn't change anything to the .C files). However, the .root test files that are already in scikit-hep-testdata, are not the ones used in JuliaHEP/UnROOT.jl#264. The .root files were added in January #111 and the update was done in June JuliaHEP/UnROOT.jl#264 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, if the .C files weren't changed and there's now a reference here connecting the ROOT file with them, then that's all that's needed for posterity. I'll merge this and make a new release.
what I intended to do (and what I do for UnROOT.jl) is that I will refresh/replace the |
Files used in uproot PR 962 ; taken from UnROOT PR 262