Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for current RNTuple files #962

Merged
merged 33 commits into from
Oct 19, 2023
Merged

feat: add support for current RNTuple files #962

merged 33 commits into from
Oct 19, 2023

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Sep 20, 2023

No description provided.

@ioanaif ioanaif force-pushed the ioanaif/rntuple-update-2 branch from 5f1ba42 to fee6d55 Compare September 20, 2023 12:20
@ioanaif ioanaif force-pushed the ioanaif/rntuple-update-2 branch from fee6d55 to ffc249a Compare September 20, 2023 12:26
Moelf
Moelf reviewed Oct 11, 2023
View reviewed changes
src/uproot/models/RNTuple.py Outdated Show resolved Hide resolved
ioanaif and others added 21 commits October 11, 2023 19:56
@ioanaif
Applies changes to const file.
559741d
@ioanaif
Adds new format test file.
31ee04d
@pre-commit-ci
style: pre-commit fixes
d673b77
@ioanaif
Tests only the new file for now.
1f53cd7
@pre-commit-ci
style: pre-commit fixes
2bed24a
@ioanaif
Adds new RNTuple schema for the footer and the split cases without th…
0fa4e15 
…e split functions.
@pre-commit-ci
style: pre-commit fixes
0e1eed9
@ioanaif
Merge branch 'main' into ioanaif/rntuple-update-2
6dbc12d
@ioanaif
Updates testing / adds more files.
7193e41
@pre-commit-ci
style: pre-commit fixes
57fc8b1
@ioanaif
Adds changes to split functionality.
b5a3d93
@pre-commit-ci
style: pre-commit fixes
d7e908a
@ioanaif
Fixes split for uint16 case.
80eded4
@pre-commit-ci
style: pre-commit fixes
a5150a6
@ioanaif
Merge branch 'main' into ioanaif/rntuple-update-2
badb2d6
@ioanaif
Fixes split for 32 and 64.
74f3f61
@pre-commit-ci
style: pre-commit fixes
e4a0bbe
@ioanaif
Fixes spelling errors.
0f3cb6e
@pre-commit-ci
style: pre-commit fixes
ebdd0a0
@ioanaif
Fixes spelling errors.
af11fc6
@ioanaif
Changes zigzag function.
c5b6b4a
@ioanaif ioanaif mentioned this pull request Oct 17, 2023
Merged
@ioanaif ioanaif requested review from Moelf and jpivarski October 19, 2023 14:09
jpivarski
jpivarski approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this on Zoom; it fixes the RNTuple metadata change and also adds split decoding.

It all looks good and I'll be merging it after the tests pass.

@jpivarski jpivarski enabled auto-merge (squash) October 19, 2023 14:41
@jpivarski jpivarski merged commit 6b1952e into main Oct 19, 2023
19 checks passed
@jpivarski jpivarski deleted the ioanaif/rntuple-update-2 branch October 19, 2023 14:48
lobis added a commit that referenced this pull request Oct 19, 2023
@lobis
Merge remote-tracking branch 'origin/fsspec-urlsplit' into fsspec-url…
c075234 
…split

* origin/fsspec-urlsplit:
  feat: add support for current RNTuple files (#962)
  chore: update pre-commit hooks (#993)
  chore: add types to most of the `uproot.source` module (#996)
  fix: make hist import optional in test_0965 (#994)
  docs: add GaetanLepage as a contributor for test (#995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

@Moelf Moelf Awaiting requested review from Moelf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioanaif @jpivarski @Moelf