Skip to content

Add Codecov CI / comment report in each PR #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Nov 2, 2024

CI passes with a comment when coverage has gone up or remains the same:

Screenshot 2024-11-01 at 7 20 13 PM

CI fails when coverage decreases:

Screenshot 2024-11-01 at 8 19 11 PM

codecov

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading to the branch within Codecov.io other than main to generate the PR comment. This approach ensures that the user-facing main branch coverage remains unaffected during a PR:

I have tested using a dummy package:

branch:

https://app.codecov.io/gh/bobleesj-test-org/bobleesj.release/commits/test-codecov

main:

https://app.codecov.io/gh/bobleesj-test-org/bobleesj.release/commits/main

Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge ready for review - needs to be merged to v0 after.

@sbillinge sbillinge merged commit 3800d60 into scikit-package:main Nov 5, 2024
1 check passed
@bobleesj bobleesj deleted the patch-10 branch November 5, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants