Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored adapters out of STH #1006

Closed
wants to merge 7 commits into from
Closed

Refactored adapters out of STH #1006

wants to merge 7 commits into from

Conversation

MichalCz
Copy link
Member

What?

Refactor of adapters to separate modules.

Why?

Before we had a set of adapters that sat in a single package and the fixes and changes
were not isolated to a single module.

Usage:

No changes in usage

How it works:

  • @scramjet/adapters has dependencies to new modules
  • @scramjet/adapter-* these are the refactored adapters

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@alicja-gruzdz
Copy link
Contributor

Thanks, @MichalCz. We'll take it as a guidance when completing #894 I'm closing this PR but I'll not delete the branch until the #894 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants