Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extract Adapters to separate modules, introduce AdapterManager #894

Draft
wants to merge 11 commits into
base: devel
Choose a base branch
from

Conversation

patuwwy
Copy link
Contributor

@patuwwy patuwwy commented Jun 27, 2023

What?

Install Runtime Adapter You will be using, in example:
npm i @scramjet/sth @scramjet/adapter-process @scramjet/adapter-docker

  • Runtime Adapters have been moved to dedicated modules.
  • Introduced AdapterManager and multiple Runtime Adapters in Host.
  • Only specified Runtime Adapters are loaded now and initialized with provided configuration.
  • Introduced ability to choose Runtime Adapter when uploading Sequence:
    si seq send <PKG> --runtime-adapter <adapter>
  • STH can be started without Runtime Adapters. No /instance, /sequence/ and /sequences endpoints are available in this mode and returns HTTP 404 with meaningful message.

Why?
supplying all adapters is redundant and causes a significant increase in the size of the STH package

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@patuwwy patuwwy force-pushed the feat/adapter-manager branch 5 times, most recently from 81975da to 8bd6f99 Compare June 30, 2023 09:06
@patuwwy patuwwy force-pushed the feat/adapter-manager branch 7 times, most recently from 0247f09 to 9e85e27 Compare July 7, 2023 09:06
@patuwwy patuwwy changed the title [WIP] Extract process adapter, introduce AdapterManager [WIP] Extract Adapters to separate modules, introduce AdapterManager Jul 7, 2023
@patuwwy patuwwy force-pushed the feat/adapter-manager branch 3 times, most recently from decd7c3 to 9e63548 Compare July 10, 2023 21:00
@patuwwy patuwwy force-pushed the feat/adapter-manager branch from 9e63548 to 035eaef Compare July 10, 2023 21:25
@patuwwy patuwwy force-pushed the feat/adapter-manager branch from 035eaef to ddc6d4f Compare July 10, 2023 21:32
@patuwwy patuwwy force-pushed the feat/adapter-manager branch 2 times, most recently from 9540e10 to b07ac76 Compare July 11, 2023 18:04
@patuwwy patuwwy force-pushed the feat/adapter-manager branch 19 times, most recently from 8645b3b to c4982ba Compare July 13, 2023 16:51
@patuwwy patuwwy force-pushed the feat/adapter-manager branch from c4982ba to ca73ddb Compare July 13, 2023 16:55
@alicja-gruzdz alicja-gruzdz mentioned this pull request Jan 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant