-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Extract Adapters to separate modules, introduce AdapterManager #894
Draft
patuwwy
wants to merge
11
commits into
devel
Choose a base branch
from
feat/adapter-manager
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81975da
to
8bd6f99
Compare
0247f09
to
9e85e27
Compare
decd7c3
to
9e63548
Compare
9e63548
to
035eaef
Compare
035eaef
to
ddc6d4f
Compare
9540e10
to
b07ac76
Compare
8645b3b
to
c4982ba
Compare
c4982ba
to
ca73ddb
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Install Runtime Adapter You will be using, in example:
npm i @scramjet/sth @scramjet/adapter-process @scramjet/adapter-docker
si seq send <PKG> --runtime-adapter <adapter>
/instance
,/sequence/
and/sequences
endpoints are available in this mode and returns HTTP 404 with meaningful message.Why?
supplying all adapters is redundant and causes a significant increase in the size of the STH package
Review checks:
These aspects need to be checked by the reviewer: