Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OrderedDict to dict #84

Closed
serhii73 opened this issue Dec 2, 2022 · 0 comments · Fixed by #88
Closed

Replace OrderedDict to dict #84

serhii73 opened this issue Dec 2, 2022 · 0 comments · Fixed by #88
Assignees
@serhii73

Comments

@serhii73
Copy link
Collaborator

serhii73 commented Dec 2, 2022

Makes sense wherever it does not affect external APIs.
e.g. if a function uses OrderedDict internally, then yes; if a function returns OrderedDict, we probably should follow a deprecation approach, e.g. deprecate that function (but keep it for a time) and provide a new one that returns a dict.
serhii73 added a commit that referenced this issue Mar 17, 2023
@serhii73
Replace OrderedDict to dict
be81c85 
Close #84
@serhii73 serhii73 mentioned this issue Mar 17, 2023
Merged
@serhii73 serhii73 self-assigned this Mar 17, 2023
serhii73 added a commit that referenced this issue Mar 20, 2023
@serhii73 @Gallaecio
Replace OrderedDict to dict (#88)
5ba328f 
* Replace OrderedDict to dict

Close #84

* fix

* Update number_parser_scripts/write_complete_language_data.py

Co-authored-by: Adrián Chaves <adrian@chaves.io>

---------

Co-authored-by: Adrián Chaves <adrian@chaves.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhii73 serhii73

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace OrderedDict to dict scrapinghub/number-parser
1 participant
@serhii73