Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OrderedDict to dict #88

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Replace OrderedDict to dict #88

merged 3 commits into from
Mar 20, 2023

Conversation

serhii73
Copy link
Collaborator

Close #84

@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Merging #88 (a2bbfb8) into master (9c96922) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          86       86           
  Lines         335      335           
  Branches       60       60           
=======================================
  Hits          332      332           
  Misses          1        1           
  Partials        2        2

@serhii73 serhii73 requested review from Gallaecio and wRAR March 17, 2023 13:05
wRAR
wRAR reviewed Mar 17, 2023
View reviewed changes
number_parser_scripts/write_complete_language_data.py Outdated
@@ -138,7 +137,13 @@ def write_complete_data():
full_supplementary_path = os.path.join(SUPPLEMENTARY_PATH, file_name)

language_data = {key: {} for key in REQUIRED_NUMBERS_DATA}
ordered_language_data = OrderedDict((key, {}) for key in REQUIRED_NUMBERS_DATA)
ordered_language_data = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now duplicates REQUIRED_NUMBERS_DATA, maybe just ordered_language_data = {key: {} for key in REQUIRED_NUMBERS_DATA}?

@serhii73 @Gallaecio
Update number_parser_scripts/write_complete_language_data.py
a2bbfb8 
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@serhii73 serhii73 merged commit 5ba328f into master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio left review comments

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace OrderedDict to dict
3 participants
@serhii73 @wRAR @Gallaecio