docs: Fixed inconsistent examples #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> path of validation models
-> how to implement SPIDERMON_VALIDATION_MODELS
-> fixing inconsistent examples
Gallaecio
approved these changes
Aug 19, 2019
Gallaecio
reviewed
Aug 19, 2019
|
Please, see if you can fix the conflicts. |
vipulgupta2048
approved these changes
Aug 19, 2019
rennerocha
requested changes
Aug 21, 2019
There was a problem hiding this comment.
@sulthonzh after the docs changes were approved, you updated your PR including an SMTP action. Please keep this PR only with the documentation changes and if you want to propose a new action with SMTP, please create a separated pull-request.
hello @rennerocha i just reseted smtp action from this PR, |
rennerocha
changed the title
|
Conflicts on this PR was fixed in #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> naming scrapy project example as tutorial not myproject, etc
-> fix how to implement SPIDERMON_VALIDATION_MODELS