Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed inconsistent examples #273

Merged
merged 4 commits into from
Sep 11, 2020
Merged

docs: Fixed inconsistent examples #273

merged 4 commits into from
Sep 11, 2020

Conversation

rennerocha
Copy link
Collaborator

This PR solves conflict problems with
#199

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #273 into master will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   72.52%   73.63%   +1.11%     
==========================================
  Files          68       68              
  Lines        2817     2966     +149     
  Branches      321      321              
==========================================
+ Hits         2043     2184     +141     
- Misses        712      720       +8     
  Partials       62       62              
Impacted Files Coverage Δ
spidermon/contrib/actions/email/ses.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/jobs/tags.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/s3.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/files.py 0.00% <0.00%> (ø)
spidermon/contrib/monitors/mixins/stats.py 100.00% <0.00%> (ø)
spidermon/contrib/actions/sentry/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/slack/notifiers.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/telegram/notifiers.py 0.00% <0.00%> (ø)
...pidermon/contrib/pytest/plugins/filter_monitors.py 100.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1cd20...af20abc. Read the comment docs.

@rennerocha rennerocha merged commit f0bf02a into scrapinghub:master Sep 11, 2020
@rennerocha rennerocha deleted the fix-docs-examples branch September 11, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants