-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 'Cancel' button is not visible in Python 3.x #312
Comments
I think the real problem is that we read the configuration without regard to encoding. Lines 19 to 23 in d3f47f3
Does this work for you? self.cp = SafeConfigParser()
self.cp.readfp(StringIO(default_config))
self.cp.read(sources)
for fname in extra_sources:
with io.open(fname) as fp:
self.cp.readfp(fp) |
No, it still doesn't work for Python 3 Line 141 in d3f47f3
print(self.root.children.keys()) still shows dict_keys([b'', b'logs', b'jobs', b'schedule.json', b'cancel.json'...
|
@Digenis Actually, I really doubt who would deactivate cancel.json. |
fixed in e3c9f91 |
I only tested whether it reads correctly a file with non-ascii-encodable resource names. |
It should be
if b'cancel.json' not in self.root.children:
for Python 3.xscrapyd/scrapyd/website.py
Lines 141 to 143 in d3f47f3
The text was updated successfully, but these errors were encountered: