Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read config with regard to encoding #315

Merged
merged 1 commit into from
Apr 22, 2019
Merged

read config with regard to encoding #315

merged 1 commit into from
Apr 22, 2019

Conversation

Digenis
Copy link
Member

@Digenis Digenis commented Apr 16, 2019

Closes #312, #292

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #315 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   68.37%   68.77%   +0.39%     
==========================================
  Files          16       16              
  Lines         819      823       +4     
  Branches       96       96              
==========================================
+ Hits          560      566       +6     
+ Misses        230      229       -1     
+ Partials       29       28       -1
Impacted Files Coverage Δ
scrapyd/config.py 85.18% <100%> (+5.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5298f9b...0db4b18. Read the comment docs.

@Digenis
Copy link
Member Author

Digenis commented Apr 17, 2019

Needs test

@Digenis
Copy link
Member Author

Digenis commented Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'Cancel' button is not visible in Python 3.x
1 participant