Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend jobtable #256

Merged
merged 3 commits into from
Nov 20, 2017
Merged

Extend jobtable #256

merged 3 commits into from
Nov 20, 2017

Conversation

Digenis
Copy link
Member

@Digenis Digenis commented Nov 15, 2017 •
edited
Loading

This improves the job listing table.
It adds a cancel endpoint (part of #254)
and rewrites the resource class (refactoring).

@codecov
Copy link

codecov bot commented Nov 15, 2017 •
edited
Loading

Codecov Report

Merging #256 into master will increase coverage by 2.1%.
The diff coverage is 32.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #256     +/-   ##
=========================================
+ Coverage   66.02%   68.13%   +2.1%     
=========================================
  Files          16       16             
  Lines         833      819     -14     
  Branches       96       87      -9     
=========================================
+ Hits          550      558      +8     
+ Misses        254      232     -22     
  Partials       29       29
Impacted Files Coverage Δ
scrapyd/website.py 59.57% <32.43%> (+16.98%) ⬆️
scrapyd/webservice.py 28.2% <0%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae9051...d78d0c9. Read the comment docs.

@Digenis Digenis added this to the 1.3.0 milestone Nov 15, 2017
@Digenis Digenis force-pushed the extend_jobtable branch 2 times, most recently from 2681016 to 2580139 Compare November 15, 2017 19:34
@Digenis Digenis force-pushed the extend_jobtable branch 3 times, most recently from 7b56a7e to 3ec3c31 Compare November 16, 2017 13:02
@Digenis Digenis merged commit d78d0c9 into scrapy:master Nov 20, 2017
@Digenis Digenis mentioned this pull request Nov 20, 2017
Closed
3 tasks
@my8100
Copy link
Collaborator

my8100 commented Apr 13, 2019

@Digenis I install the latest version of Scrapyd via git clone and find that the cancel button is hidden since its style is set to "display: none;". The result is the same when items_dir is not set in the scrapyd.conf file.

image

@Digenis
Copy link
Member Author

Digenis commented Apr 14, 2019

@my8100, any chance that you deactivated cancel.json
in any of the scrapyd configuration files?

Note to self: I think we should list the available webservices
on the webpage's root to ease troubleshooting in issues like this one.

@my8100
Copy link
Collaborator

my8100 commented Apr 15, 2019

#312

@my8100 my8100 mentioned this pull request Apr 20, 2019
Closed
my8100 added a commit to my8100/scrapydweb that referenced this pull request Apr 28, 2019
@my8100
Temp support for Scrapyd v1.3.0 (not released)
8e55156 
scrapy/scrapyd#256
This improves the job listing table.
It adds a cancel endpoint (part of #254)
and rewrites the resource class (refactoring).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Digenis @my8100