Remove duplicate computer beeps#1401
Merged
paulkaplan merged 1 commit intoscratchfoundation:masterfrom Feb 7, 2018
kyleplo:master
Merged
Remove duplicate computer beeps#1401paulkaplan merged 1 commit intoscratchfoundation:masterfrom kyleplo:master
paulkaplan merged 1 commit intoscratchfoundation:masterfrom
kyleplo:master
Conversation
Contributor
|
Sorry @kyleplo I messed up on this and didn't see that it was not linked to a help-wanted issue. As mentioned in #1356, which was identical to this PR,
I know this looks like a small change, but it is important to not submit PRs for issues that haven't been confirmed "help-wanted" because of things like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#1355
Proposed Changes
Removes the duplicate computer beeps sound
Reason for Changes
You shouldn't have two of the same sounds
Test Coverage
If you search for "computer beep", there are 3 results, but only 2 different sounds