removed "computer beep"#1356
Closed
apple502j wants to merge 1 commit intoscratchfoundation:developfrom
apple502j:patch-3
Closed
removed "computer beep"#1356apple502j wants to merge 1 commit intoscratchfoundation:developfrom apple502j:patch-3
apple502j wants to merge 1 commit intoscratchfoundation:developfrom
apple502j:patch-3
Conversation
Contributor
|
Thanks, but this should be resolved in the source project that JSON is generated from. Please refrain from submitting PRs for issues that are not labeled as “help wanted”. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#1355
Proposed Changes
Remove "Computer Beep" sound.
Reason for Changes
Same as "Computer Beeps2"
Test Coverage
1.Add Sound Library
2. Search "computer"
3. There should be 2 sounds