Revert "round x and y like Scratch 2 does"#1497
Revert "round x and y like Scratch 2 does"#1497rschamp merged 1 commit intoscratchfoundation:developfrom
Conversation
|
@amazinigmech2418 The issue is not marked as "help wanted". Please don't submit pull request for issues without the "help wanted" label. |
|
@kyleplo That's not something the CONTRIBUTING file actually says. |
|
@Kenny2github @kyleplo @joker314 This is a MAJOR glitch. Even if it isn't "help wanted", it needs to be done. See the issue it fixes. ST members are saying it is needed. |
|
@amazinigmech2418 why did you ping me? I'm not involved with this at all (though now I am). It is a major problem, but nevertheless you shouldn't open pull requests until they're marked "help wanted". If it's not marked help wanted, that means an ST member will open a pull for it eventually, and outside contributions are not needed. |
|
@amazinigmech2418 Thanks for bringing this up and for this PR. In general, @kyleplo and @Kenny2github are correct that we would prefer all community PRs to have an associated "help wanted" issue, since we would like to come to consensus internally on how to resolve an issue before reviewing PRs. Major and obvious regressions like this are a gray area however. @mzgoddard @cwillisf I think we need to resolve this in scratch-render if we choose this method, since as-is this solution is like making all move operations followed by |
Reverts #1453
Fixes scratchfoundation/scratch-gui#2911
The rounding is stopping position setting of floats. The rounding needs to be done in the display instead.
If you change the position by 0.4, it would change by 0 if this isn't merged.