Local Variables #2548
Merged
Local Variables #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2018
Contributor
Author
|
Note: Tests are currently failing and will continue to fail until the changes from the PRs on scratch-blocks and scratch-vm are pulled in. |
paulkaplan
reviewed
Jul 6, 2018
src/components/prompt/prompt.jsx
Outdated
| <Box className={styles.optionsRow}> | ||
| <label> | ||
| <input | ||
| checked |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
force-pushed
the
variable-modal-options
branch
from
df7d522 to
00b11c0
Compare
…M to scratch-blocks for checking for conflicts in all sprites when attempting to create a global var.
kchadha
force-pushed
the
variable-modal-options
branch
from
00b11c0 to
55af45c
Compare
Contributor
Author
|
@paulkaplan This PR finally builds, so it's ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-vm#1278
Proposed Changes
Allow specifying variables as local vs. global via options in the variable modal. Variable modals on the stage display a message indicating that variable being created will be global. Pass var names from VM to scratch-blocks for checking for conflicts in all sprites when attempting to create a global var.
Test Coverage
Manual testing.
Test branch set up at:
Related PRs
This PR should be merged last.
This PR is related to the following PRs:
scratchfoundation/scratch-blocks#1621 <--- This PR should be merged first
scratchfoundation/scratch-vm#1301 <--- This PR should be merged second
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet