Variable scope #1301
Merged
Variable scope #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2018
Contributor
|
Can you update this to include serializing scope to xml? |
paulkaplan
approved these changes
Jul 6, 2018
Contributor
paulkaplan
left a comment
paulkaplan
left a comment
There was a problem hiding this comment.
LG. Are there any existing tests for the var_create etc. events? If so we should probably add to them, if not then ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Allows creating local variables.
Towards resolving #1278
Proposed Changes
Allows creating local variables. Adds variable to appropriate target based on a new
isLocalflag from avar_createevent.Global vars now check for conflict against all target local variables instead of just the currently selected one.
Test Coverage
Manual testing.
Related PRs
This PR should be merged second.
This PR is related to the following PRs:
scratchfoundation/scratch-blocks#1621
scratchfoundation/scratch-gui#2548