can remix, can save as copy; project state names are more consistent#3461
can remix, can save as copy; project state names are more consistent#3461benjiwheeler merged 2 commits intoscratchfoundation:developfrom
Conversation
benjiwheeler
changed the title
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Right now this adds "Remix" to the menu bar, along side "Save" and "Save as Copy". That state shouldn't ever be possible. We will either display "Remix" or we will display "Save" and "Save as Copy". Since we wouldn't want to release that state to beta, I wouldn't want to merge this — did you plan on addressing that in a follow-up? If so I think we should have that follow-up ready before merging.
| requestNewProject, | ||
| saveProject | ||
| remixProject, | ||
| updateProject, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rschamp
added
pr - changes requested
needs discussion
and removed
pr - needs review
labels
|
OK, I'm leaving off remix entirely, when canRemix is false. |
benjiwheeler
force-pushed
the
remix
branch
2 times, most recently
from
702093f to
58c655e
Compare
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Looks good, however tests are failing — I reran them and they failed in the same way, so I think the tests need to be updated (not a transient failure).
rschamp
added
pr - changes requested
and removed
needs discussion
pr - needs review
labels
made remixing, saving as copy states; made project state naming more consistent changed meaning of canCreateNew to true creation fixed project-saver-hoc test removed Remix option from standalone player menu; renamed canSaveAsCopy to canCreateCopy added parenthesis missing from rebase fixed create new test
2 participants
Commit alongside scratchfoundation/scratch-www#2222
Resolves
Proposed Changes
Introduces support for Remixing and Saving as a copy.
For now, these are done using the general create project functionality in scratch-storage; that means these won't have connections to their parent/original projects.
Test Coverage
None yet
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet