Revert "Adds BorderedMenuItem and use it for delete menu"#4374
Merged
paulkaplan merged 1 commit intodevelopfrom Jan 17, 2019
Merged
Revert "Adds BorderedMenuItem and use it for delete menu"#4374paulkaplan merged 1 commit intodevelopfrom
paulkaplan merged 1 commit intodevelopfrom
Conversation
Contributor
|
Try it out: revert-4359-delete-select I'm a bot, not actually @rschamp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4359
After talking with @carljbowman @benjiwheeler, we are going to bring this back out and work on the design before bringing it back. We don't want to block the high priority bugfixes that are going to production. Thanks for the submission @apple502j, sorry about the confusion.