Add BorderedMenuItem and use it for delete menu, with updated style#4385
Merged
benjiwheeler merged 3 commits intodevelopfrom Jan 18, 2019
Merged
Add BorderedMenuItem and use it for delete menu, with updated style#4385benjiwheeler merged 3 commits intodevelopfrom
benjiwheeler merged 3 commits intodevelopfrom
Conversation
Contributor
|
Try it out: revert-4374-revert-4359-delete-select I'm a bot, not actually @rschamp! |
Contributor
Author
|
@carljbowman @kathymakes What do you think of this? Previously, this looked like: With this code change, it will instead look like: ...that orange is |
7c37ff2 to
3bbfe94
Compare
Contributor
Author
Contributor
Author
|
Merging, per approval by @carljbowman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Reverts the reversion #4374 , and adds updated styling
Resolves #4345
Proposed Changes
Adds BorderedMenuItem, which has a border at the top and becomes red when hovered
Use it for Delete menu (also reorder it)
Reason for Changes
Some people accidentally delete sprites because there was no difference between this and the others