Skip to content

Add BorderedMenuItem and use it for delete menu, with updated style#4385

Merged
benjiwheeler merged 3 commits intodevelopfrom
revert-4374-revert-4359-delete-select
Jan 18, 2019
Merged

Add BorderedMenuItem and use it for delete menu, with updated style#4385
benjiwheeler merged 3 commits intodevelopfrom
revert-4374-revert-4359-delete-select

Conversation

@benjiwheeler
Copy link
Contributor

Reverts the reversion #4374 , and adds updated styling

Resolves #4345

Proposed Changes

Adds BorderedMenuItem, which has a border at the top and becomes red when hovered
Use it for Delete menu (also reorder it)

Reason for Changes

Some people accidentally delete sprites because there was no difference between this and the others

@rschamp
Copy link
Contributor

rschamp commented Jan 18, 2019

Try it out: revert-4374-revert-4359-delete-select

I'm a bot, not actually @rschamp!

@benjiwheeler
Copy link
Contributor Author

benjiwheeler commented Jan 18, 2019

@carljbowman @kathymakes What do you think of this?

Previously, this looked like:

image

image

With this code change, it will instead look like:

image

image

...that orange is error-light; alternatively, we could use error-primary:

image

@benjiwheeler
Copy link
Contributor Author

benjiwheeler commented Jan 18, 2019

Now using the middle-intensity of the three shades of orange: error-primary

image

@benjiwheeler benjiwheeler removed the request for review from paulkaplan January 18, 2019 21:53
@benjiwheeler
Copy link
Contributor Author

Merging, per approval by @carljbowman!

@benjiwheeler benjiwheeler merged commit 4498ba3 into develop Jan 18, 2019
@benjiwheeler benjiwheeler deleted the revert-4374-revert-4359-delete-select branch April 9, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants