Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with Node 12.16.2 #4025

Closed
southwolf opened this issue May 27, 2020 · 3 comments · Fixed by #4026
Closed

Build failure with Node 12.16.2 #4025

southwolf opened this issue May 27, 2020 · 3 comments · Fixed by #4026
Assignees
@southwolf @benjiwheeler
Labels
developer facing priority 3

Comments

@southwolf
Copy link
Contributor

southwolf commented May 27, 2020 •
edited
Loading

image

Steps to Reproduce

git pull
npm i

According to sass/node-sass#2632

https://github.com/sass/node-sass/releases/tag/v4.12.0

Node-sass needs upgrading to 4.12.0 (or higher) to support NodeJS 12

Operating System and Browser

MacOS 10.15.4
NodeJS 12.16.2
Node-gyp 6.1.0
@southwolf southwolf mentioned this issue May 27, 2020
Merged
benjiwheeler added a commit that referenced this issue Jun 25, 2020
@benjiwheeler
Merge pull request #4026 from southwolf/fix-node12-support
6a4ed0e 
Add node12 support, Fix #4025
benjiwheeler added a commit that referenced this issue Jun 25, 2020
@benjiwheeler
Revert "Add node12 support, Fix #4025"
150296a
benjiwheeler added a commit that referenced this issue Jun 25, 2020
@benjiwheeler
Merge pull request #4142 from LLK/revert-4026-fix-node12-support
9dd8775 
Revert "Add node12 support, Fix #4025"
@benjiwheeler
Copy link
Contributor

It looks like #4026 caused a problem with our SASS media queries and/or SASS variables.

You can see this when the screen gets narrow:

Production:
image

With #4026:
image

Some relevant issues and posts:

@benjiwheeler benjiwheeler reopened this Jun 25, 2020
@benjiwheeler
Copy link
Contributor

@southwolf Please take a look and let us know if you want to keep working on this.

@apple502j apple502j mentioned this issue Jul 5, 2020
Closed
@apple502j apple502j mentioned this issue Aug 4, 2020
Merged
@rschamp
Copy link
Contributor

rschamp commented Aug 4, 2020 •
edited
Loading

Resolved by #4274 and #4265

@rschamp rschamp closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@southwolf southwolf

@benjiwheeler benjiwheeler

Labels
developer facing priority 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add node12 support, Fix #4025 southwolf/scratch-www
4 participants
@southwolf @BryceLTaylor @rschamp @benjiwheeler