feat: set code tx support #1600
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request updates the dependency versions in the Changes
Sequence Diagram(s)sequenceDiagram
participant TX as Transaction
participant F as txsToTxsData Function
participant TD as TransactionData
TX->>F: Pass transaction
F->>TX: Call SetCodeAuthorizations()
TX-->>F: Return authorization list
F->>TD: Populate AuthorizationList
TD-->>F: Build complete transaction data
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
colinlyguo
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
go.work.sumis excluded by!**/*.sumrollup/go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
common/version/version.go(1 hunks)rollup/go.mod(4 hunks)rollup/internal/controller/sender/sender.go(1 hunks)rollup/internal/controller/watcher/l1_watcher.go(1 hunks)rollup/internal/controller/watcher/l2_watcher.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- rollup/internal/controller/sender/sender.go
🧰 Additional context used
🪛 golangci-lint (1.62.2)
rollup/internal/controller/watcher/l1_watcher.go
8-8: "github.com/ethereum/go-ethereum/consensus/misc" imported and not used
(typecheck)
🔇 Additional comments (2)
common/version/version.go (1)
8-8: LGTM: Version increment for new feature.Version bump from v4.4.87 to v4.4.88 aligns with the addition of set code transaction support.
rollup/internal/controller/watcher/l2_watcher.go (1)
103-121: LGTM: Added authorization list support.The addition of
AuthorizationListfield and its initialization usingSetCodeAuthorizations()properly implements the set code transaction support.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1600 +/- ##
===========================================
- Coverage 51.72% 51.72% -0.01%
===========================================
Files 157 157
Lines 12555 12556 +1
===========================================
Hits 6494 6494
- Misses 5497 5498 +1
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I think would be better to merge it into #1583 once scroll-tech/da-codec#43 is merged as well
what's the rationale for doing this? e.g. there seem no conflicts merging into |
colinlyguo
force-pushed
the
feat-support-setcode-tx
branch
5 times, most recently
from
f1418eb to
896d958
Compare
changed the base branch to feat/use-codec-v6. |
colinlyguo
force-pushed
the
feat-support-setcode-tx
branch
from
896d958 to
6f74c82
Compare
Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
New Features
Chores