feat(bridge-history-api): update l2geth dependency for Pectra readiness #1601
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThis pull request updates dependency versions in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1601 +/- ##
========================================
Coverage 51.72% 51.72%
========================================
Files 157 157
Lines 12555 12555
========================================
Hits 6494 6494
Misses 5497 5497
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bridge-history-api/go.mod (1)
38-38: Addition ofmmap-goDependency.A new indirect dependency,
github.com/edsrzf/mmap-go v1.0.0, has been introduced. Please ensure that its inclusion is necessary and that its usage (if any) is accompanied by appropriate documentation and testing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
bridge-history-api/go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
bridge-history-api/go.mod(4 hunks)common/version/version.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- common/version/version.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: tests
🔇 Additional comments (9)
bridge-history-api/go.mod (9)
11-11: Update togo-ethereumDependency Version.The version of
github.com/scroll-tech/go-ethereumhas been updated tov1.10.14-0.20250225152658-bcfdb48dd939, which aligns with the PR's objective to update the L2 geth dependency for Pectra readiness. Please verify that any API changes or incompatibilities introduced by this commit are fully tested.
20-20: Bump Fastcache Version.The dependency for
github.com/VictoriaMetrics/fastcachehas been incremented fromv1.12.1tov1.12.2. This minor version bump should be checked to ensure that no regressions or breaking changes have been introduced.
33-33: Pinninggolang-setto a Specific Commit.The dependency
github.com/deckarep/golang-setis now fixed at commitv0.0.0-20180603214616-504e848d77ea. Confirm that this specific commit is stable and that its functionality meets the project’s requirements.
55-55: Replacement withhashicorp/golang-lruDependency.The dependency
github.com/hashicorp/golang-lruis now included at versionv0.5.5-0.20210104140557-80c98217689d, replacinggithub.com/holiman/billy. Verify that this replacement meets the expected functionality and performance characteristics.
86-86: Addition of Prometheus TSDB Dependency.The dependency
github.com/prometheus/tsdbhas been added at versionv0.7.1. Ensure that its integration with your Prometheus metrics setup is working as intended.
88-88: Update in Notify Library.The dependency
github.com/rjeczalik/notifyis now updated tov0.9.1, replacing the previous dependency (github.com/rogpeppe/go-internal). Please verify that the updated notify library fulfills your notification requirements without introducing regressions.
91-91: Update toda-codecDependency.The dependency
github.com/scroll-tech/da-codechas been updated tov0.1.3-0.20250210041951-d028c537b995. Confirm that this update aligns with compatibility and performance expectations within the project.
116-116: ReviewnpipeVersion Pinning.The dependency
gopkg.in/natefinch/npipe.v2is pinned atv2.0.0-20160621034901-c1b8fa8bdcce. Please double-check if this version is still appropriate for the Windows-specific functionalities, or if an upgrade might be warranted for improved stability or features.
117-117: Multiple Versions ofurfave/cliDetected.Both
github.com/urfave/cli/v2(direct dependency on line 13) andgopkg.in/urfave/cli.v1(indirect dependency on line 117) are present. Please validate that the indirect dependency on version 1 is necessary and does not conflict with the usage of version 2.
This reverts commit e732acd.
colinlyguo
deleted the
update-l2geth-dependency-in-bridge-history-for-pectra-readiness
branch
Purpose or design rationale of this PR
Updating the dependency of
l2gethinbridge-history, supporting set code transactions.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit