Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Implement error handling for all forms #10

Closed
CamiloGarciaLaRotta opened this issue Feb 4, 2019 · 1 comment
Closed

Implement error handling for all forms #10

CamiloGarciaLaRotta opened this issue Feb 4, 2019 · 1 comment
Assignees
@CamiloGarciaLaRotta
Labels
enhancement New feature or request
Milestone
Deliverable 2

Comments

@CamiloGarciaLaRotta
Copy link
Contributor

CamiloGarciaLaRotta commented Feb 4, 2019 •
edited
Loading

After all the scrapers are completed, fine-tune the error messages based on the user stories concerning the chrome extension.
e.g. adding a job application without being logged in/being logged in.
@CamiloGarciaLaRotta CamiloGarciaLaRotta added the enhancement New feature or request label Feb 4, 2019
@CamiloGarciaLaRotta CamiloGarciaLaRotta added this to the Deliverable 1 milestone Feb 4, 2019
@CamiloGarciaLaRotta CamiloGarciaLaRotta changed the title Setup form input handling Implement error handling for all forms Feb 8, 2019
CamiloGarciaLaRotta added a commit that referenced this issue Feb 16, 2019
@CamiloGarciaLaRotta
feat: implement login functionality
2977b70 
- Advances #10 by implementing error handling of the login form
- Login is now a reducer component. It performs the authentication
  and via a callback returns the JWT to the App component.
- Services has a side-effect method "authenticate" which POSTs the
  credentials to the Auth backend.
  If the login is succesful, it returns the JWT to Login
  If the login fails, it changes the state of Login to DisplayError
- Services has a new type "authResponse" to decode the HTTP response
- valueFromEvent was refactored to Services because its used in
  multiple components

Closes #16
@CamiloGarciaLaRotta CamiloGarciaLaRotta mentioned this issue Feb 16, 2019
Merged
5 tasks
CamiloGarciaLaRotta added a commit that referenced this issue Feb 18, 2019
@CamiloGarciaLaRotta
feat: implement login functionality
06fca54 
- Advances #10 by implementing error handling of the login form
- Login is now a reducer component. It performs the authentication
  and via a callback returns the JWT to the App component.
- Services has a side-effect method "authenticate" which POSTs the
  credentials to the Auth backend.
  If the login is succesful, it returns the JWT to Login
  If the login fails, it changes the state of Login to DisplayError
- Services has a new type "authResponse" to decode the HTTP response
- valueFromEvent was refactored to Services because its used in
  multiple components

Closes #16
CamiloGarciaLaRotta added a commit that referenced this issue Feb 19, 2019
@CamiloGarciaLaRotta
feat: implement login functionality
48a3eec 
- Advances #10 by implementing error handling of the login form
- Login is now a reducer component. It performs the authentication
  and via a callback returns the JWT to the App component.
- Services has a side-effect method "authenticate" which POSTs the
  credentials to the Auth backend.
  If the login is succesful, it returns the JWT to Login
  If the login fails, it changes the state of Login to DisplayError
- Services has a new type "authResponse" to decode the HTTP response
- valueFromEvent was refactored to Services because its used in
  multiple components

Closes #16
CamiloGarciaLaRotta added a commit that referenced this issue Feb 20, 2019
@CamiloGarciaLaRotta
feat: implement login functionality
1462c3b 
- Advances #10 by implementing error handling of the login form
- Login is now a reducer component. It performs the authentication
  and via a callback returns the JWT to the App component.
- Services has a side-effect method "authenticate" which POSTs the
  credentials to the Auth backend.
  If the login is succesful, it returns the JWT to Login
  If the login fails, it changes the state of Login to DisplayError
- Services has a new type "authResponse" to decode the HTTP response
- valueFromEvent was refactored to Services because its used in
  multiple components

Closes #16
@CamiloGarciaLaRotta CamiloGarciaLaRotta removed this from the Deliverable 1 milestone Feb 25, 2019
@CamiloGarciaLaRotta CamiloGarciaLaRotta self-assigned this Feb 26, 2019
@CamiloGarciaLaRotta CamiloGarciaLaRotta added this to the Deliverable 2 milestone Feb 26, 2019
@CamiloGarciaLaRotta
Copy link
Contributor Author

handled by 324c3f1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CamiloGarciaLaRotta CamiloGarciaLaRotta

Labels
enhancement New feature or request
Projects
None yet
Milestone
Deliverable 2
Development

No branches or pull requests
1 participant
@CamiloGarciaLaRotta