MERSCOPE: don't try to load unexisting elements #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 41.54% 41.24% -0.30%
==========================================
Files 16 16
Lines 869 885 +16
==========================================
+ Hits 361 365 +4
- Misses 508 520 +12
|
|
@quentinblampey looks good, do you think we can merge it? |
|
Hello @giovp, |
|
yes, let's do it! Thank you @quentinblampey ! |
giovp
approved these changes
Nov 29, 2023
|
Nice work! A minor thing, please update the changelog when making a PR 😊 (gonna update it in main for this PR). |
|
Thanks @LucaMarconato, and sorry for forgetting, next time I will update the changelog! |
lucas-diedrich
pushed a commit
to lucas-diedrich/spatialdata-io
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Blampey Quentin <quentin.blampey@centralesupelec.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as what was done for the Xenium reader: if the files that contain the points/shapes/table are not existing, they are not loaded (but a warning is shown).