Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Update Metadata.getReplicas API #380

Open
dkropachev opened this issue Nov 22, 2024 · 0 comments
Open

3.x: Update Metadata.getReplicas API #380

dkropachev opened this issue Nov 22, 2024 · 0 comments
Assignees
@Bouncheck

Comments

@dkropachev
Copy link
Collaborator

Metadata User-facing getReplicas API changes

If driver have user-facing API to get replica list we need to adapt it to tablets:

  1. To accomodate tablet requirements new optional parameter table should be added, alternatively another method could be implemented with additional table parameter.
  2. If target table is not tablet-based it should return old vnode-based result
  3. If target table is tablet-based it should return known tablet replicas for given token
  4. if there is no tablet record for given token, it should return empty list
Bouncheck added a commit to Bouncheck/java-driver that referenced this issue Jan 7, 2025
@Bouncheck
Add usesTablets property to KeyspaceMetadata
788c35f 
Adds the field to `KeyspaceMetadata` that informs if the keyspace has tablets
enabled. It is initialized with value `false` and updated to `true` only if
the keyspace is discovered in `system_schema.scylla_keyspaces` and its entry
has non-null value in `initial_tablets` column. The update happens on schema
refresh.

Updates `Metadata#getReplicas` to use this keyspace metadata information to
decide whether to look for replicas in the token map or tablet map.

Fixes scylladb#380.
@Bouncheck Bouncheck mentioned this issue Jan 7, 2025
Merged
Bouncheck added a commit to Bouncheck/java-driver that referenced this issue Jan 7, 2025
@Bouncheck
Add usesTablets property to KeyspaceMetadata
29328a2 
Adds the field to `KeyspaceMetadata` that informs if the keyspace has tablets
enabled. It is initialized with value `false` and updated to `true` only if
the keyspace is discovered in `system_schema.scylla_keyspaces` and its entry
has non-null value in `initial_tablets` column. The update happens on schema
refresh.

Updates `Metadata#getReplicas` to use this keyspace metadata information to
decide whether to look for replicas in the token map or tablet map.

Fixes scylladb#380.
Bouncheck added a commit to Bouncheck/java-driver that referenced this issue Jan 7, 2025
@Bouncheck
Add usesTablets property to KeyspaceMetadata
1d543db 
Adds the field to `KeyspaceMetadata` that informs if the keyspace has tablets
enabled. It is initialized with value `false` and updated to `true` only if
the keyspace is discovered in `system_schema.scylla_keyspaces` and its entry
has non-null value in `initial_tablets` column. The update happens on schema
refresh.

Updates `Metadata#getReplicas` to use this keyspace metadata information to
decide whether to look for replicas in the token map or tablet map.

Fixes scylladb#380.
dkropachev pushed a commit that referenced this issue Jan 7, 2025
@Bouncheck
Add usesTablets property to KeyspaceMetadata (#403)
8664e60 
Adds the field to `KeyspaceMetadata` that informs if the keyspace has tablets
enabled. It is initialized with value `false` and updated to `true` only if
the keyspace is discovered in `system_schema.scylla_keyspaces` and its entry
has non-null value in `initial_tablets` column. The update happens on schema
refresh.

Updates `Metadata#getReplicas` to use this keyspace metadata information to
decide whether to look for replicas in the token map or tablet map.

Fixes #380.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bouncheck Bouncheck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bouncheck @dkropachev