3.x: Add usesTablets to KeyspaceMetadata
#403
Merged
+156
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
reviewed
Jan 3, 2025
Bouncheck
force-pushed
the
scylla-3.x-getReplicas-rework
branch
from
b172384 to
788c35f
Compare
Bouncheck
changed the title
usesTablets to KeyspaceMetadatausesTablets to KeyspaceMetadata
Bouncheck
changed the title
usesTablets to KeyspaceMetadatausesTablets to KeyspaceMetadata
dkropachev
requested changes
Jan 7, 2025
driver-core/src/main/java/com/datastax/driver/core/Metadata.java
Outdated
Show resolved
Hide resolved
Bouncheck
force-pushed
the
scylla-3.x-getReplicas-rework
branch
from
788c35f to
29328a2
Compare
dkropachev
reviewed
Jan 7, 2025
driver-core/src/main/java/com/datastax/driver/core/Metadata.java
Outdated
Show resolved
Hide resolved
Bouncheck
force-pushed
the
scylla-3.x-getReplicas-rework
branch
from
29328a2 to
1d543db
Compare
Adds the field to `KeyspaceMetadata` that informs if the keyspace has tablets enabled. It is initialized with value `false` and updated to `true` only if the keyspace is discovered in `system_schema.scylla_keyspaces` and its entry has non-null value in `initial_tablets` column. The update happens on schema refresh. Updates `Metadata#getReplicas` to use this keyspace metadata information to decide whether to look for replicas in the token map or tablet map. Fixes scylladb#380.
dkropachev
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the field to
KeyspaceMetadatathat informs if the keyspace has tabletsenabled. It is initialized with value
falseand updated totrueonly ifthe keyspace is discovered in
system_schema.scylla_keyspacesand its entryhas non-null value in
initial_tabletscolumn. The update happens on schemarefresh.
Updates
Metadata#getReplicasto use this keyspace metadata information todecide whether to look for replicas in the token map or tablet map.
Fixes #380.