Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start-all.sh --target-directory option error #2398

Closed
tzach opened this issue Sep 22, 2024 · 0 comments · Fixed by #2399
Closed

start-all.sh --target-directory option error #2398

tzach opened this issue Sep 22, 2024 · 0 comments · Fixed by #2399
Labels
documentation Documentation related
Milestone
Monitoring 4.8.1

Comments

@tzach
Copy link
Contributor

tzach commented Sep 22, 2024

start-all.sh CLI docs has a small mistake:

--target-directory - If set, prometheus/targets/ directory will be set as a root directory for the target files
the file names should be scylla_server.yml, node_exporter_servers.yml, and # List Scylla Manager end points

the file name is scylla_server.yml should be scylla_servers.yml (with s suffix)
@tzach tzach added the documentation Documentation related label Sep 22, 2024
@amnonh amnonh added this to the Monitoring 4.8.1 milestone Sep 22, 2024
@amnonh amnonh mentioned this issue Sep 22, 2024
Merged
@amnonh amnonh closed this as completed in f0070af Sep 22, 2024
amnonh added a commit that referenced this issue Sep 22, 2024
@amnonh
start-all.sh: Validate files in target and support es-linus
c6f0ee7 
This patch address multiple issues when using the `--target-directory`
option.

1. Fix a documentation bug, that uses the wrong file name for scylla
   targets.
2. Add validation step that validate that all target files are inside
   the directory.
3. Add an option for SE-Linux to bind the directory correctly.

Fixes #2398

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
(cherry picked from commit f0070af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related
Projects
None yet
Milestone
Monitoring 4.8.1
Development

Successfully merging a pull request may close this issue.

start-all.sh: Validate files in target and support es-linus amnonh/scylla-grafana-monitoring
2 participants
@tzach @amnonh