start-all.sh: Validate files in target and support es-linus #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch address multiple issues when using the `--target-directory` option. 1. Fix a documentation bug, that uses the wrong file name for scylla targets. 2. Add validation step that validate that all target files are inside the directory. 3. Add an option for SE-Linux to bind the directory correctly. Fixes scylladb#2398 Signed-off-by: Amnon Heiman <amnon@scylladb.com>
tzach
reviewed
Sep 22, 2024
| if [ ! -f $TARGET_DIRECTORY/node_exporter_servers.yml ]; then | ||
| echo "Warning, using $TARGET_DIRECTORY for Prometheus traget directory, node_exporter_servers.yml is missing, make sure to create it, or node-exporter targets will be missing" | ||
| fi | ||
| if [ ! -f $TARGET_DIRECTORY/scylla_manager_agents.yml ]; then |
There was a problem hiding this comment.
If one does not use Manager, this warning is rudendent.
Its look like Prometheus do work without Manager agent or server
There was a problem hiding this comment.
I'll make the manager optional (or add an option to by pass it) in the future, then it will be ok not to add the files, I'm trying to avoid the situation that something is wrong with the setup but there is no indication to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch address multiple issues when using the
--target-directoryoption.Fixes #2398